feat: add active-turn message delivery controls by ClapFy · Pull Request #5396 · pingdotgg/t3code

ClapFy · 2026-08-05T09:49:21Z

What Changed

Adds a Messages while working setting to web and mobile with two delivery behaviors:

Steer (the default) sends the message into the active turn.
Queue stores follow-ups per thread and sends them FIFO, one turn at a time, after the current turn finishes.

The running web composer now keeps Stop generation visible beside the mode-specific send action. Mobile uses the same preference and snapshots it onto each outbox entry so existing queued work keeps its intended delivery behavior.

Codex sessions now use turn/steer when a turn is active, matching the steering behavior already supported by the other provider adapters. A successful steer reaffirms the running turn to orchestration so no stale pending-turn projection is left behind.

Why

While an agent was working, the composer only exposed Stop and did not let users choose whether a follow-up should affect the current turn or wait for the next one. That made rapid follow-ups awkward and left queue semantics inconsistent between web and mobile.

Delivery safeguards

Queues are durable per thread and preserve FIFO order without an artificial message cap.
Stable message and command IDs make retries idempotent.
Only one dispatcher may own a queued web message at a time.
The next queued message pauses after a non-interruption send failure and requires an explicit retry.
Mobile retains its bounded exponential retry delay and sends only the head of each thread queue.
Queue drain waits for a ready, connected thread, preventing overlapping turns and token-burning retry loops.

Verification

vp test run packages/contracts/src/settings.test.ts apps/mobile/src/state/thread-outbox.test.ts apps/server/src/provider/Layers/CodexSessionRuntime.test.ts apps/server/src/provider/Layers/CodexAdapter.test.ts apps/server/src/orchestration/Layers/ProjectionPipeline.test.ts apps/web/src/webThreadOutbox.test.ts apps/web/src/components/settings/settingsSearch.test.ts — 137 tests passed
vp lint across all 23 changed TypeScript files with --report-unused-disable-directives
vp fmt across all 23 changed TypeScript files
Package type checks passed for contracts, web, mobile, and server
Isolated T3 Code web environment:
- Queue mode drained two follow-ups FIFO exactly once and cleared persisted outbox storage
- Steer mode injected the follow-up into the active Codex turn exactly once
- Running composer exposed Stop beside Queue/Steer
T3 Code Dev on iOS Simulator: Queue and Steer flows verified
git diff --check

Model: GPT-5.6 Sol | Harness: Codex in T3 Code

Note

Add active-turn message delivery controls with 'steer' and 'queue' modes

Introduces ActiveTurnMessageBehavior ('steer' or 'queue', default 'steer') to contracts, client settings, and mobile preferences, controlling what happens when a user sends a message while a thread is actively running.
In 'steer' mode, the message is sent directly into the active Codex turn via a new turn/steer API call; in 'queue' mode, the message is held in a local outbox and delivered once the thread is idle.
Adds a persistent web thread outbox (webThreadOutbox.ts) with per-thread FIFO queues, cross-tab localStorage sync, deduplication, and pause/retry controls; mobile outbox gains a matching activeTurnMessageBehavior field on queued messages.
The web composer (ChatComposer.tsx) and mobile composer (ThreadComposer.tsx) update their primary action labels and enabled state based on the current behavior and phase ('Queue message', 'Steer active turn', or 'Send message').
Settings UIs on both web (SettingsPanels.tsx) and mobile (SettingsRouteScreen.tsx) expose a 'Messages while working' control that persists the user's choice.
Risk: sends during an active turn now have a brief async delay on mobile while awaitActiveTurnMessageBehavior waits for preferences to settle before enqueuing.

^{Macroscope summarized 56e5d17.}

Note

Medium Risk
Changes orchestration-facing Codex turn start/steer paths and multi-client message delivery timing; mistakes could duplicate turns, drop queued messages, or mis-steer active work, though stable command IDs and explicit deferral logic mitigate this.

Overview
Adds activeTurnMessageBehavior (steer | queue, default steer) to contracts and surfaces it as Messages while working in web and mobile settings.

Steer sends follow-ups into the running turn; queue holds per-thread FIFO outboxes until the turn is idle. Web gets a new webThreadOutbox store (localStorage, cross-tab merge, single-dispatcher guard, pause/retry on failure). Mobile persists the preference, waits for preferences to settle before send, snapshots behavior on each outbox entry, and only defers delivery while busy when behavior is queue (or omitted on legacy entries).

While a turn is running, web and mobile composers show Stop alongside a send action labeled Steer or Queue instead of blocking send entirely. Web drains the outbox when the thread is ready and shows a queued-count row with Retry when delivery is paused.

Codex turn/steer is used when the session is already running; a synthetic turn/started reaffirms the active turn so orchestration projection does not leave a stale pending turn. Tests cover outbox rules, Codex steer mapping, and steer reconciliation in the projection pipeline.

^{Reviewed by Cursor Bugbot for commit 56e5d17. Bugbot is set up for automated code reviews on this repo. Configure here.}

coderabbitai · 2026-08-05T09:49:31Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d83c4c7-3f50-4d35-8bd9-d2fac8851f66

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

cursor

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 56e5d17. Configure here.}

cursor · 2026-08-05T10:48:10Z

+      isSendBusy,
+      isServerThread,
+      phase,
+    });


Web send ignores settings hydration

Medium Severity

The ChatView's message queuing logic accesses settings.activeTurnMessageBehavior before localStorage hydration. This can cause the first message sent after a page load to incorrectly use the default steer behavior instead of a user's queue preference.

^{Triggered by learned rule: Feature flag hooks with per-stage defaults must gate on settings hydration}

^{Reviewed by Cursor Bugbot for commit 56e5d17. Configure here.}

cursor · 2026-08-05T10:48:10Z

+  session: Pick<ProviderSession, "status" | "activeTurnId">,
+): TurnId | undefined {
+  return session.status === "running" ? session.activeTurnId : undefined;
+}


Codex steer skipped while starting

Medium Severity

Mobile outbox delivery treats orchestration starting as busy but still sends when the queued snapshot is steer. resolveCodexSteeringTurnId only steers when the provider session is running, so follow-ups during starting fall through to turn/start instead of turn/steer, conflicting with steer semantics and projection reaffirm logic.

Additional Locations (2)

apps/mobile/src/state/thread-outbox-model.ts#L196-L198

apps/mobile/src/state/use-thread-outbox-drain.ts#L377-L379

^{Reviewed by Cursor Bugbot for commit 56e5d17. Configure here.}

cursor · 2026-08-05T10:48:10Z

+    (input.hasQueuedMessages ||
+      (input.activeTurnMessageBehavior === "queue" &&
+        (input.phase === "running" || input.isSendBusy)))
+  );


Queue mode ignores starting session

Medium Severity

In queue mode, shouldQueueWebThreadMessage only treats phase === "running" (or local send busy) as active work. derivePhase maps session.status === "starting" to connecting, so after the first turn is acknowledged but the session is still starting, a follow-up can bypass the outbox and hit startThreadTurn directly instead of queuing.

Additional Locations (1)

apps/web/src/components/chat/ChatComposer.tsx#L3252-L3253

^{Reviewed by Cursor Bugbot for commit 56e5d17. Configure here.}

macroscopeapp · 2026-08-05T10:49:28Z

Approvability

Verdict: Needs human review

This PR introduces a significant new feature (active-turn message delivery controls) with cross-platform changes to mobile, web, and server, including new state management and API integration. Three unresolved review comments identify medium-severity bugs in the core feature logic.

^{You can customize Macroscope's approvability policy. Learn more.}

feat: add active-turn message controls

e20fa4b

github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Aug 5, 2026

macroscopeapp Bot reviewed Aug 5, 2026

View reviewed changes

Comment thread apps/mobile/src/state/use-thread-composer-state.ts

Comment thread apps/mobile/src/state/use-thread-outbox-drain.ts

Comment thread apps/web/src/webThreadOutbox.ts

fix: address active-turn message review feedback

56e5d17

ClapFy marked this pull request as ready for review August 5, 2026 10:43

cursor Bot reviewed Aug 5, 2026

View reviewed changes

Navigation Menu

Uh oh!

feat: add active-turn message delivery controls - #5396

feat: add active-turn message delivery controls#5396
ClapFy wants to merge 2 commits into
pingdotgg:mainfrom
ClapFy:agent/active-turn-message-controls

ClapFy commented Aug 5, 2026 •

edited by macroscopeapp Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Aug 5, 2026

Uh oh!

cursor Bot Aug 5, 2026

Uh oh!

cursor Bot Aug 5, 2026

Uh oh!

macroscopeapp Bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ClapFy commented Aug 5, 2026 • edited by macroscopeapp Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

Delivery safeguards

Verification

Add active-turn message delivery controls with 'steer' and 'queue' modes

Uh oh!

coderabbitai Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Aug 5, 2026

Choose a reason for hiding this comment

Web send ignores settings hydration

Uh oh!

cursor Bot Aug 5, 2026

Choose a reason for hiding this comment

Codex steer skipped while starting

Uh oh!

cursor Bot Aug 5, 2026

Choose a reason for hiding this comment

Queue mode ignores starting session

Uh oh!

macroscopeapp Bot commented Aug 5, 2026

Approvability

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ClapFy commented Aug 5, 2026 •

edited by macroscopeapp Bot

Loading

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading